[HOTFIX] ConfigStep: commitGraph.generationVersion=1 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generation number v2 is better for algorithmic reasons, but it is backwards-compatible with version 1 and in doing so requires reading more data from disk. That extra data load causes a performance degradation in the typical case. Let's avoid that for now, until a non-backwards-compatible version is ready that avoids this performance problem. Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation number v2 is better for algorithmic reasons, but it is
backwards-compatible with version 1 and in doing so requires reading
more data from disk. That extra data load causes a performance
degradation in the typical case.
Let's avoid that for now, until a non-backwards-compatible version is
ready that avoids this performance problem.