[heft-lint] Fix ESLint 9 regression where TypeScript program is no longer reused #5428
+40
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
Contributor
Author
|
Apparently there is another code path that tries to process this object, but it is only hit in 4 of our build test projects and not anywhere else... Edit: the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in heft-lint-plugin for ESLint@>=9 where the TypeScript program from the compiler was no longer being reused, resulting in a full duplicate parse and analysis of the source code.
Details
The
toJSONoverride was marking theprogramsproperty onlanguageOptions.parserOptionsnon-enumerable (rather than returning an alternative representation without the property), causing the config finalization step that clones the object to discard the property.How it was tested
Ran the local build test projects with rule violations to verify that linting still occurs. Used the CPU profiler to verify that the program was not recreated.
Impacted documentation
None.