Enhance LookupByPath, Fix win32 paths in webpack-workspace-resolve-plugin #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
TheLarkInn
as code owners
D4N14L
approved these changes
Dec 17, 2024
Add more support for delimiter overrides per method.
Also tap hooks earlier to avoid sequencing issues.
dmichon-msft
force-pushed
the
lookup-enhancements
branch
from
157c494 to
fc04182
Compare
D4N14L
approved these changes
Dec 18, 2024
D4N14L
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds more functionality to
@rushstack/lookup-by-path, especially with respect to overriding the delimiter per-method.Fixes path parsing on Windows in
@rushstack/webpack-workspace-resolve-plugin.Details
Adds new methods to
LookupByPath<TItem>:isEmpty(): booleanget(query: string, delimiter?: string): TItem | undefinedhas(query: string, delimiter?: string): booleanEnhances all read/write methods with the optional
delimiter?: stringparameter to allow overriding the delimiter used to parse the input.Since the Rush cache file contains only
/as the directory separator, updates the parsing inWorkspaceLayoutCacheto parse all paths using/as the delimiter when hydratingLookupByPathinstances.How it was tested
Added unit tests.
Impacted documentation
API documentation for
LookupByPath.