[node-core-library] Fix an issue where attempting to acquire multiple LockFiles at the same time on POSIX would cause the second to immediately be acquired without releasing the first.
#4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks on the same resource at the same time.
…cking the CredentialCache file until the credential has been acquired.
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
D4N14L
reviewed
Sep 12, 2024
rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel <[email protected]>
Co-authored-by: David Michon <[email protected]>
Co-authored-by: David Michon <[email protected]>
D4N14L
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where attempting to acquire multiple
LockFiles at the same time on POSIX would cause the second to immediately be acquired without releasing the first.It also renames
LockFile.acquiretoLockFile.acquireAsyncand refactors the credential management code in the Rush Azure Storage plugin to only lock the credential cache after a new credential has been acquired.Details
The lockfile issue was fixed by keeping a list of in-proc acquired lockfiles. If one already exists, acquiring a lockfile will fail early, before touching the disk.
How it was tested
Introduced a unit test.