Get web-build-tools using PNPM

apps/rush-lib/src/cli/actions/BaseRushAction.ts

@@ -50,7 +50,7 @@ export abstract class BaseRushAction extends CommandLineAction {
 
   private _ensureEnvironment(): void {
     /* tslint:disable-next-line:no-string-literal */
-    let environmentPath: string = process.env['PATH'];
+    let environmentPath: string | undefined = process.env['PATH'];
     environmentPath = path.join(this.rushConfiguration.commonTempFolder, 'node_modules', '.bin') +
       path.delimiter + environmentPath;
     /* tslint:disable-next-line:no-string-literal */

apps/rush-lib/src/cli/actions/PublishAction.ts

@@ -256,7 +256,7 @@ export default class PublishAction extends BaseRushAction {
   }
 
   private _npmPublish(packageName: string, packagePath: string): void {
-    const env: { [key: string]: string } = PublishUtilities.getEnvArgs();
+    const env: { [key: string]: string | undefined } = PublishUtilities.getEnvArgs();
     const args: string[] = ['publish'];
 
     if (this.rushConfiguration.projectsByName.get(packageName)!.shouldPublish) {
@@ -291,7 +291,7 @@ export default class PublishAction extends BaseRushAction {
   }
 
   private _packageExists(packageConfig: RushConfigurationProject): boolean {
-    const env: { [key: string]: string } = PublishUtilities.getEnvArgs();
+    const env: { [key: string]: string | undefined } = PublishUtilities.getEnvArgs();
     if (this._registryUrl.value) {
       env['npm_config_registry'] = this._registryUrl.value; // tslint:disable-line:no-string-literal
     }

apps/rush-lib/src/cli/utilities/PublishUtilities.ts

@@ -171,8 +171,8 @@ export default class PublishUtilities {
     return LOOSE_PKG_REGEX.test(version);
   }
 
-  public static getEnvArgs(): { [key: string]: string } {
-    const env: { [key: string]: string } = {};
+  public static getEnvArgs(): { [key: string]: string | undefined } {
+    const env: { [key: string]: string | undefined } = {};
 
     // Copy existing process.env values (for nodist)
     Object.keys(process.env).forEach((key: string) => {
@@ -186,11 +186,11 @@ export default class PublishUtilities {
     command: string,
     args: string[] = [],
     workingDirectory: string = process.cwd(),
-    env?: { [key: string]: string }
+    env?: { [key: string]: string | undefined }
   ): void {
 
     let relativeDirectory: string = path.relative(process.cwd(), workingDirectory);
-    const envArgs: { [key: string]: string } = PublishUtilities.getEnvArgs();
+    const envArgs: { [key: string]: string | undefined } = PublishUtilities.getEnvArgs();
 
     if (relativeDirectory) {
       relativeDirectory = `(${relativeDirectory})`;

apps/rush-lib/src/data/RushConfiguration.ts

@@ -231,7 +231,8 @@ export default class RushConfiguration {
    * this looks something like "/usr/username/"
    */
   public static getHomeDirectory(): string {
-    const unresolvedUserFolder: string = process.env[(process.platform === 'win32') ? 'USERPROFILE' : 'HOME'];
+    const unresolvedUserFolder: string | undefined
+      = process.env[(process.platform === 'win32') ? 'USERPROFILE' : 'HOME'];
     const homeFolder: string = path.resolve(unresolvedUserFolder);
     if (!fsx.existsSync(homeFolder)) {
       throw new Error('Unable to determine the current user\'s home directory');

apps/rush-lib/src/utilities/Npm.ts

@@ -11,7 +11,7 @@ export default class Npm {
   public static publishedVersions(
     packageName: string,
     cwd: string,
-    env: { [key: string]: string }
+    env: { [key: string]: string | undefined }
   ): string[] {
     const versions: string[] = [];
     try {

apps/rush-lib/src/utilities/Utilities.ts

@@ -212,7 +212,7 @@ export default class Utilities {
    * The current directory will be set to the specified workingDirectory.
    */
   public static executeCommand(command: string, args: string[], workingDirectory: string,
-    suppressOutput: boolean = false, environmentVariables?: { [key: string]: string }): void {
+    suppressOutput: boolean = false, environmentVariables?: { [key: string]: string | undefined }): void {
 
     Utilities._executeCommandInternal(command, args, workingDirectory,
       suppressOutput ? undefined : [0, 1, 2],
@@ -224,7 +224,7 @@ export default class Utilities {
    * The current directory will be set to the specified workingDirectory.
    */
   public static executeCommandAndCaptureOutput(command: string, args: string[], workingDirectory: string,
-    environmentVariables?: { [key: string]: string }): string {
+    environmentVariables?: { [key: string]: string | undefined }): string {
 
     const  result: child_process.SpawnSyncReturns<Buffer>
       = Utilities._executeCommandInternal(command, args, workingDirectory,
@@ -301,7 +301,7 @@ export default class Utilities {
   public static executeShellCommand(
     command: string,
     workingDirectory: string,
-    environmentVariables?: { [key: string]: string },
+    environmentVariables?: { [key: string]: string | undefined },
     captureOutput: boolean = false
   ): child_process.SpawnSyncReturns<Buffer> {
     let shellCommand: string = process.env.comspec || 'cmd';
@@ -337,7 +337,7 @@ export default class Utilities {
   public static executeShellCommandAsync(
     command: string,
     workingDirectory: string,
-    environmentVariables?: { [key: string]: string },
+    environmentVariables?: { [key: string]: string | undefined },
     captureOutput: boolean = false
   ): child_process.ChildProcess {
     let shellCommand: string = process.env.comspec || 'cmd';
@@ -423,7 +423,7 @@ export default class Utilities {
   private static _executeCommandInternal(
     command: string, args: string[], workingDirectory: string,
     stdio: (string|number)[] | undefined,
-    environmentVariables: { [key: string]: string } | undefined): child_process.SpawnSyncReturns<Buffer> {
+    environmentVariables: { [key: string]: string | undefined } | undefined): child_process.SpawnSyncReturns<Buffer> {
 
     const options: child_process.SpawnSyncOptions = {
       cwd: workingDirectory,

common/changes/@microsoft/api-extractor/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/api-extractor",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/api-extractor",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build-karma/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-karma",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-karma",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build-mocha/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-mocha",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-mocha",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build-sass/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-sass",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-sass",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build-serve/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-serve",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-serve",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build-typescript/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-typescript",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-typescript",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build-webpack/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-webpack",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-webpack",
+  "email": "[email protected]"
+}

common/changes/@microsoft/gulp-core-build/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build",
+  "email": "[email protected]"
+}

common/changes/@microsoft/node-core-library/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/node-core-library",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/node-core-library",
+  "email": "[email protected]"
+}

common/changes/@microsoft/set-webpack-public-path-plugin/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/set-webpack-public-path-plugin",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/set-webpack-public-path-plugin",
+  "email": "[email protected]"
+}

common/changes/@microsoft/ts-command-line/nickpape-test-pnpm_2018-01-05-02-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/ts-command-line",
+      "comment": "Get web-build-tools building with pnpm",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/ts-command-line",
+  "email": "[email protected]"
+}

common/config/rush/nonbrowser-approved-packages.json

@@ -245,6 +245,10 @@
       "name": "jest-cli",
       "allowedCategories": [ "libraries", "other" ]
     },
+    {
+      "name": "jest-resolve",
+      "allowedCategories": [ "libraries" ]
+    },
     {
       "name": "jju",
       "allowedCategories": [ "libraries" ]