Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-heft-plugin] Remove the Jest postinstall step. #3790

Merged
merged 2 commits into from
Nov 29, 2022
+11 −109
Merged

[jest-heft-plugin] Remove the Jest postinstall step. #3790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8578354
Remove the Jest postinstall step.
iclanton Nov 28, 2022
fe5ce8c
Rush change.
iclanton Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@rushstack/heft-jest-plugin/remove-postinstall_2022-11-28-23-57.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/heft-jest-plugin",
"comment": "Remove a postinstall step that patches Jest in-place. This is better achieved with a PNPM patch. See https://github.com/microsoft/rushstack/pull/3790 for more information.",
"type": "minor"
}
],
"packageName": "@rushstack/heft-jest-plugin"
}
107 changes: 0 additions & 107 deletions heft-plugins/heft-jest-plugin/includes/jestScriptTransformerPatch.js
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions heft-plugins/heft-jest-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"build": "heft build --clean",
"start": "heft test --clean --watch",
"_phase:build": "heft build --clean",
"_phase:test": "heft test --no-build",
"postinstall": "node ./includes/jestScriptTransformerPatch.js"
"_phase:test": "heft test --no-build"
},
"peerDependencies": {
"@rushstack/heft": "^0.48.8"
Expand Down