-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Extractor] Add missing required parameter for getResolvedModule to ensure that modules can resolve accurately with Node16/nodenext support #3434
Conversation
…ypescript can resolve accurately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Let's get this in 😄 This is a critical fix needed for us to ship our FAST vNext packages.
8afde43
to
18b51b5
Compare
Thanks for the review @DanielRosenwasser - build is passing with updated types! @iclanton, @octogonz, @D4N14L, @apostolisms - Apologies for the ping, but curious if anyone is available to work with us on getting this out the door to unblock our release? Thank you! |
…ypescript can resolve accurately
Summary
With the addition of
Node16
andnodenext
, Typescript now requires the mode to be passed in order to accurately resolve modules. This PR adds support formode
thanks to the help of @DanielRosenwasser and does so in a way that returns undefined gracefully in case the fn isn't supported in older versions.This resolves #3433.
Details
mode
getModeForUsageLocation
which maps to the TS equivalentHow it was tested
Tested locally with Typescript 4.7.2 and the error is gone, API Extractor succeeds.