[node-core-library] Fix Async.forEachAsync concurrency #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
iclanton
reviewed
May 10, 2022
common/changes/@rushstack/node-core-library/fix-async-concurrency_2022-05-10-00-46.json
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where
Async.forEachAsyncoperating on an async iterable would exceed the max concurrency specified in the options.Details
The state of "waiting for iterator to return" was not tracked as a concurrent operation, so more instances of the waiter function could be paused at the iterator than the maximum concurrency specified in the original call.
How it was tested
Affects concurrency of
rush build. Validated that after the fix was applied that max concurrency of a highly-cached build was capped at the number of CPU cores.