-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Update rush-project.json to follow new proposed schema. #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz and
sachinjoseph
as code owners
January 15, 2022 18:14
@iclanton your CI build failed - I think we have to publish the new Rush before we can update the rigs |
octogonz
reviewed
Jan 18, 2022
octogonz
reviewed
Jan 18, 2022
octogonz
reviewed
Jan 18, 2022
octogonz
reviewed
Jan 18, 2022
octogonz
reviewed
Jan 18, 2022
common/changes/@microsoft/rush/update-rush-project.json_2022-01-15-17-49.json
Outdated
Show resolved
Hide resolved
octogonz
approved these changes
Jan 18, 2022
Co-authored-by: Pete Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the schema of
rush-project.json
to follow the proposal here: #2300 (comment)Note that this change removes the validation step that ensures phases/operations are defined in the repo's
command-line.json
How it was tested
elliot-nelson/rush-phased-builds-example#7