[rush] Add support for phased commands. #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble and
sachinjoseph
as code owners
iclanton
force-pushed
the
phased-commands
branch
2 times, most recently
from
3e4d777 to
115e248
Compare
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
common/changes/@microsoft/rush/phased-commands_2021-12-25-04-47.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 29, 2021
octogonz
reviewed
Dec 29, 2021
|
@iclanton After this PR is merged, will we be ready to announce the phased commands feature? If not, could you detail the remaining work items in your PR description? I'm super excited to see this coming together! 😁👍 |
…roperties of Flag parameters.
Co-authored-by: Pete Gonzalez <[email protected]>
…ctor to private member functions.
iclanton
force-pushed
the
phased-commands
branch
from
cf22d4c to
c630e6e
Compare
|
Yup, this should be ready to release. I'd like to publish a release candidate before we do a real release, but this should be all that's required for MVP. |
octogonz
approved these changes
Dec 30, 2021
elliot-nelson
added a commit
to elliot-nelson/rush-phased-builds-example
that referenced
this pull request
Jan 3, 2022
Various updates for microsoft/rushstack#3113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fills in support for phased commands (see design #2300), including support for caching custom and phased commands' output.
Details
This change updates how the ProjectTaskSelector works by effectively removing the concept of "bulk" commands from everywhere but the
command-line.jsonconfig file. Instead, bulk commands are translated to phased commands with a single phase (and an upstream dependency on that phase if"ignoreDependencyOrder"is set tofalse).How it was tested
Tested against this repo (rushstack), https://github.com/elliot-nelson/rush-phased-builds-example, and a large internal repo.