Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush-lib] increase maxBuffer to 10mb when executeCommand #3105

Merged
merged 2 commits into from
Jan 5, 2022
Merged

[rush-lib] increase maxBuffer to 10mb when executeCommand #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6d902
[rush-lib] set maxBuffer to 10mb when excuting command
F3n67u Dec 21, 2021
429ddd6
Update common/changes/@microsoft/rush/feat-increase-maxBuffer_2021-12…
F3n67u Dec 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/rush-lib/src/utilities/Utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,8 @@ export class Utilities {
stdio: stdio,
env: keepEnvironment
? environment
: Utilities._createEnvironmentForRushCommand({ initialEnvironment: environment })
: Utilities._createEnvironmentForRushCommand({ initialEnvironment: environment }),
maxBuffer: 10 * 1024 * 1024 // Set default max buffer size to 10MB
};

// This is needed since we specify shell=true below.
Expand Down
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/feat-increase-maxBuffer_2021-12-21-03-55.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix an issue that occurs when running a command with a selection argument with a Git ref (like `--from git:main`) in a repo with a pnpm lockfile larger than 1MB.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}