Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] Disable the AWS credential provider logic to mitigate a problematic peer dependency #2550

Merged
merged 3 commits into from
Mar 12, 2021
Merged

[rush] Disable the AWS credential provider logic to mitigate a problematic peer dependency #2550

merged 3 commits into from
Mar 12, 2021

Conversation

octogonz
Copy link
Collaborator

Summary

Mitigates #2547

How it was tested

The problematic dependency is eliminated. The feature is still partially usable via the RUSH_BUILD_CACHE_WRITE_CREDENTIAL environment variable.

@octogonz octogonz mentioned this pull request Mar 12, 2021
Closed
@octogonz octogonz requested a review from patmill as a code owner March 12, 2021 01:41
@octogonz octogonz enabled auto-merge March 12, 2021 01:41
dmichon-msft
dmichon-msft approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@dmichon-msft dmichon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ultimately we need to pull the credential provider logic for both the Azure and AWS build caches out into a separate installable tool.

@octogonz
Copy link
Collaborator Author

Looks good. Ultimately we need to pull the credential provider logic for both the Azure and AWS build caches out into a separate installable tool.

@dmichon-msft Yes, but under no circumstances is react-native a reasonable dependency to get installed by Rush.

@octogonz octogonz disabled auto-merge March 12, 2021 01:59
@octogonz octogonz merged commit 9ab572d into master Mar 12, 2021
@octogonz octogonz deleted the octogonz/issue-2547 branch March 12, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmichon-msft dmichon-msft dmichon-msft approved these changes

@D4N14L D4N14L D4N14L approved these changes

@apostolisms apostolisms Awaiting requested review from apostolisms

@halfnibble halfnibble Awaiting requested review from halfnibble

@iclanton iclanton Awaiting requested review from iclanton

@sachinjoseph sachinjoseph Awaiting requested review from sachinjoseph

@patmill patmill Awaiting requested review from patmill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@octogonz @D4N14L @dmichon-msft