Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Rush install fails with Rush 5.10.1 and pnpm 3.5.3 #1392

Closed
1 of 2 tasks
calebmshafer opened this issue Jul 16, 2019 · 3 comments · Fixed by #1393
Closed
1 of 2 tasks

[rush] Rush install fails with Rush 5.10.1 and pnpm 3.5.3 #1392

calebmshafer opened this issue Jul 16, 2019 · 3 comments · Fixed by #1393
Assignees

Comments

@calebmshafer
Copy link

calebmshafer commented Jul 16, 2019

Is this a feature or a bug?

  • Feature
  • Bug

Updating to Rush 5.10.1 and pnpm 3.5.3 from pnpm 2.25.7, I can now successfully rush update (thanks to #1347). However, when I try to run a rush install it fails saying The shrinkwrap is missing the following dependencies:. A subsequent rush update will work though.

The workflow I followed is:

  1. Update rush.json
  2. Delete existing shrinkwrap.yaml
    • common\temp did not exist either
  3. Run node common/scripts/install-run-rush.js update --full. Which succeeds and appears to work properly
    • Same issue if rush update instead of --full is run here.
  4. Run node common/scripts/install-run-rush.js install. This fails with the shrinkwrap is missing dependencies error.

There is a repro repo here, https://github.com/calebmshafer/imodeljs_rush_bug_repro.

What is the expected behavior?

I expected rush update to create the pnpm-lock.yaml file correctly so rush install works after the lock file is initially created.

Please provide the tool version, Node.js version and OS.

  • Tool: Rush
  • Tool Version:
  • Node Version: 10.15.3
  • OS: Windows 10 1809
@sachinjoseph sachinjoseph self-assigned this Jul 16, 2019
@sachinjoseph
Copy link
Member

I can repro this. Looking into this.

@sachinjoseph
Copy link
Member

#1393

iclanton added a commit that referenced this issue Jul 17, 2019
[rush] Fix #1392  "rush install not working on pnpm 3.5" by getting the  temporary project dependency key from the shrinkwrap
@calebmshafer
Copy link
Author

I can confirm Rush 5.10.3 is now working with pnpm 3.5.3 for our repo. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants