Skip to content

Commit

Permalink
[rush] supports "rush-pnpm patch-remove" command (#4911)
Browse files Browse the repository at this point in the history
* feat: add rush-pnpm patch-remove

* chore: rush change

* Rush change.

---------

Co-authored-by: Cheng Liu <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
  • Loading branch information
3 people authored Sep 9, 2024
1 parent cf7f5e3 commit 6a5ac8a
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Support the `rush-pnpm patch-remove` command.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
17 changes: 17 additions & 0 deletions libraries/rush-lib/src/cli/RushPnpmCommandLineParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,22 @@ export class RushPnpmCommandLineParser {
}
break;
}
case 'patch-remove': {
const semver: typeof import('semver') = await import('semver');
/**
* The "patch-remove" command was introduced in pnpm version 8.5.0
*/
if (semver.lt(this._rushConfiguration.packageManagerToolVersion, '8.5.0')) {
this._terminal.writeErrorLine(
PrintUtilities.wrapWords(
`Error: The "pnpm patch-remove" command is added after [email protected].` +
` Please update "pnpmVersion" >= 8.5.0 in ${RushConstants.rushJsonFilename} file and run "rush update" to use this command.`
) + '\n'
);
throw new AlreadyReportedError();
}
break;
}

// Known safe
case 'audit':
Expand Down Expand Up @@ -447,6 +463,7 @@ export class RushPnpmCommandLineParser {
const subspaceConfigFolder: string = this._subspace.getSubspaceConfigFolderPath();

switch (commandName) {
case 'patch-remove':
case 'patch-commit': {
// why need to throw error when pnpm-config.json not exists?
// 1. pnpm-config.json is required for `rush-pnpm patch-commit`. Rush writes the patched dependency to the pnpm-config.json when finishes.
Expand Down

0 comments on commit 6a5ac8a

Please sign in to comment.