Merge pull request #3166 from iclanton/fix-warningsInSuccessfulBuild

Fix the "allowWarningsInSuccessfulBuild" option in command-line.json
microsoft · Jan 18, 2022 · 4ba7374 · 4ba7374
2 parents d84c03b + 1469c4c
commit 4ba7374
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/apps/rush-lib/src/logic/taskExecution/ProjectTaskRunner.ts b/apps/rush-lib/src/logic/taskExecution/ProjectTaskRunner.ts
@@ -52,7 +52,6 @@ export interface IProjectTaskRunnerOptions {
   commandToRun: string;
   isIncrementalBuildAllowed: boolean;
   projectChangeAnalyzer: ProjectChangeAnalyzer;
-  allowWarningsInSuccessfulBuild?: boolean;
   taskName: string;
   phase: IPhase;
 }
@@ -114,9 +113,7 @@ export class ProjectTaskRunner extends BaseTaskRunner {
     this._projectChangeAnalyzer = options.projectChangeAnalyzer;
     this._packageDepsFilename = `package-deps_${phase.logFilenameIdentifier}.json`;
     this.warningsAreAllowed =
-      EnvironmentConfiguration.allowWarningsInSuccessfulBuild ||
-      options.allowWarningsInSuccessfulBuild ||
-      false;
+      EnvironmentConfiguration.allowWarningsInSuccessfulBuild || phase.allowWarningsOnSuccess || false;
     this._logFilenameIdentifier = phase.logFilenameIdentifier;
   }
 

diff --git a/common/changes/@microsoft/rush/fix-warningsInSuccessfulBuild_2022-01-18-16-07.json b/common/changes/@microsoft/rush/fix-warningsInSuccessfulBuild_2022-01-18-16-07.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix the \"allowWarningsInSuccessfulBuild\" option in bulk commands defined in common/config/command-line.json.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}