Content model: fix keyboard delete issue on Android #2402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Android IMEs (such as Gboard and Samsung keyboard) don't support
KeyboardEvent
well. Thekey
property of keyboard events will always beUnidentified
when using these IMEs. To workaround this issue, we need to handleInputEvent
instead.The PR changes the DOM event handling logic in
EditPlugin
:Unidentified
keyboard event on Android, check the nextbeforeinput
event.deleteContentBackward
corresponds toBackspace
key, anddeleteContentForward
corresponds toDelete
key.keyboardDelete
.