Keep start property and marker (if supported) when copying list from WordOnline #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
changed the title
BryanValverdeU
requested review from
JiuqingSong,
Andres-CT98,
flyingbee2012,
ianeli1 and
juliaroldi
JiuqingSong
reviewed
Aug 25, 2022
| this.listTypes.pop(); | ||
| } | ||
|
|
||
| if (this.listTypes[listTypesLength - 1] == ListType.Ordered) { | ||
| this.node.style.listStyleType = ''; |
There was a problem hiding this comment.
why set to empty? What if the parent level list also have a list style type, should we also follow?
There was a problem hiding this comment.
Removed this part of code as the scope of this PR is only going to be pasting from Word Online.
However, I found that if a list have a 'custom' list style type and we indent or outdent, Vlist is going to remove the list style and will have a different list style. Adding a gif to explain better:
There was a problem hiding this comment.
So this should be a separate issue, right?
Does it repro without this change?
There was a problem hiding this comment.
Yes, separate issue.
There was a problem hiding this comment.
ok. please open issue to track.
JiuqingSong
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying lists from Word Online, sometimes the marker is not saved and the start of the list is reset:
For example, this content in Word Online
Some of the Word Online markers in the clipboard are unsupported. If I tried to use them the marker would look bad, so only can support some of the Word Online Markers
Why some of the markers are not supported:
The clipboard provided from WordOnline does not contain the data-leveltext hence we cannot use it to change the list marker