Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Jan 25, 2024

Description

Bridgeless mode can now be enabled by setting the environment variable USE_BRIDGELESS=1. This build flag will enable bridgeless bits, but you can still disable it at runtime by implementing RNXHostConfig.isBridgelessEnabled.

See the full announcement here: https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks#new-architecture-updates

Test plan

  1. If necessary, clone react-native-test-app, then link in react-native-host
    cd ../react-native-test-app
    git checkout tido/bridgeless
    yarn clean
    yarn
    yarn link -r ../rnx-kit/packages/react-native-host
    cd example
    
  2. In a separate terminal, start Metro server and keep it running for the rest of the session
    yarn start
    
  3. Test old architecture
    pod install --project-directory=ios
    yarn ios
    
  4. Test new architecture
    • In ios/Podfile, change :fabric_enabled to true
    • Repeat commands in step 2
    • Verify that "Fabric" is on
  5. Test new architecture + bridgeless
    • In ios/Podfile, change :bridgeless_enabled to true
    • Repeat commands in step 2
    • Verify that "Bridgeless" is on
  6. Test Hermes
    • In ios/Podfile, change :hermes_enabled to true
    • Repeat commands in step 2
    • Verify that "Hermes" is on

Screenshots

New Architecture + Bridgeless + Hermes
Simulator Screenshot - iPhone 15 Pro - 2024-01-25 at 09 45 06 Simulator Screenshot - iPhone 15 Pro - 2024-01-24 at 21 07 40 Simulator Screenshot - iPhone 15 Pro - 2024-01-25 at 09 32 59

@tido64 tido64 requested a review from Saadnajmi January 25, 2024 10:00
@github-actions github-actions bot added the feature: sdk This is related to 1RN SDK label Jan 25, 2024
@kelset
Copy link
Contributor

kelset commented Feb 1, 2024

Testing iOS:

old arch fabric bridgeless hermes

1 - Old arch works

2 - Fabric works

3 - bridgeless work (but safeareaview errors up)

4 - hermes works

the only weird thing about it was safe area view error, but nothing worth bringing up I guess.


Testing Android:

old arch fabric bridgeless

1 - Android base

2 - Fabric on

3 - Bridgeless mode

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works (see comment above), changes LGTM

@tido64 tido64 merged commit 20864b4 into main Feb 1, 2024
@tido64 tido64 deleted the tido/bridgeless branch February 1, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: sdk This is related to 1RN SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants