Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix images missing alternate text in RAI Vision dashboard for accessibility #2463

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Dec 15, 2023

Description

fix images missing alternate text in RAI Vision dashboard for accessibility

[Programmatic Access – Responsible AI Dashboard – Image Explorer View>Select Instance]: Image does not have alternate text or a role of none or presentation present under "Selected Instance" dialog.

User Experience:
Visually impaired users who depend on screen reader and navigate in scan mode will not be able to understand the information provided or purpose of the image properly. Due to which it would be difficult to access controls present on the dialog efficiently.

Repro Steps:
Open RAI Dashboard
Navigate the "Vision Data Explorer" section, navigate the "Image Explorer View" tab and all the controls present under it.
Navigate to "Error Instances/Success instances" section.
Select an Error instance "Can".
"Selected Instance" dialog opens. Navigate all the controls present on the dialog.
Run the AI tool.
Observe and verify whether Image does have alternate text or a role of none or presentation or not.
Actual Result:

Image does not have alternate text or a role of none or presentation present under "Selected Instance" dialog.

Observation: Alt attribute is not defined for the image 26 present under "Error Instances" section.

Screen reader behavior:
NVDA and JAWS screen reader focus does not move to image in (Browse/VPC) mode.
When Narrator (Scan mode) focus moves to image, it announces as "Unlabeled graphic."
Expected Result:
Image should have alternate text or a role of none or presentation present for Error Instances " Image 26 Water bottle" under the "Selected Instance" dialog.

Note: The same issue exists throughout the application.
Issue:
Ensures elements have alternate text or a role of none or presentation (image-alt - https://accessibilityinsights.io/info-examples/web/image-alt)

Element path:
#flyoutImage_26
Snippet:

<img id="flyoutImage_26" src="data:image/jpg;base64,..." class="ms-Image-image is-loaded ms-Image-image--contain ms-Image-image--portrait is-fadeIn image-884">

How to fix:
Fix any of the following:
Element does not have an alt attribute
aria-label attribute does not exist or is empty
aria-labelled by attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role="none" or role="presentation"
Environment:
Chrome version 117.0.0.0

====

This accessibility issue was found using Accessibility Insights for Web 2.40.0 (axe-core 4.7.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Screenshot of fastpass with zero errors after fix:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-image-alt-accessibility branch from 38afbda to 9bbbfa4 Compare December 15, 2023 21:48
1 similar comment
@imatiach-msft
Copy link
Contributor Author

close re-open for CI

@imatiach-msft imatiach-msft merged commit 4f7bda6 into main Dec 18, 2023
@imatiach-msft imatiach-msft deleted the ilmat/fix-image-alt-accessibility branch December 18, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants