fix confusion matrix highcharts heatmap keyboard focus order accessibility #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
Advitya17
approved these changes
Dec 8, 2023
imatiach-msft
force-pushed
the
ilmat/fix-conf-matrix-keyboard-accessibility
branch
from
c228c04 to
dad0b94
Compare
imatiach-msft
deleted the
ilmat/fix-conf-matrix-keyboard-accessibility
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix confusion matrix highcharts heatmap keyboard focus order accessibility
Screenshot of confusion matrix with fixed keyboard focus order (note it's difficult to portray this bug without understanding which key is pressed when since this is an issue with up/down arrow keys going to the wrong cell):
Based on this stack overflow I discovered this is occurring due to the "reversed" attribute on the y axis:
https://stackoverflow.com/questions/64450163/highcharts-js-keyboard-navigation-issue
[Keyboard navigation – Responsible AI Dashboard – Vision Dashboard>Model overview]: Keyboard focus order is not logical while navigating the 'Confusion matrix' chart using up/down arrow keys.
User Experience:
People who depend on keyboard for navigation will get impacted if focus order is not logical while navigating the chart using up and down arrow keys. As a result, the end user will not be able to access the chart and will find difficulty in understanding the 'Confusion matrix'.
Repro Steps:
Open RAI dashboard
Navigate to the "Model overview" section and select 'Confusion matrix' tab.
Navigate the 'Confusion matrix' chart using arrow keys.
Observe whether keyboard focus order is logical or not while navigating using up and down arrow keys.
Actual Result:
Keyboard focus order is not logical while navigating the 'Confusion matrix' chart using up/down arrow keys.
Observation:
While navigating the 'Confusion matrix' chart, up and down arrow keys are performing reverse functionality.
When focus is on the first cell i.e., on the "Can", by pressing up arrow, the focus is moving to the below cell i.e., on the "Carton".
Expected Result:
Keyboard focus order should be in logical order while navigating the 'Confusion matrix' chart using up/down arrow keys.
Checklist