fix pivot focus indicator for accessibility #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
hawestra
approved these changes
Dec 7, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix pivot focus indicator for accessibility
Specifically, fixes the model overview pivots, causal pivots and feature importances pivots in the dashboard.
[Usable – Responsible AI Dashboard – Vision Dashboard>Model overview]: Only one side of the keyboard focus indicator is visible on the "Metrices visualization" tab.
User Experience:
Users who depend on keyboard for navigation will get impacted if focus is visible only one side on the control. As a result, they will not be able to know the exact focus of the keyboard while navigating the page.
Note: User credentials should NOT be included in the bug.
Repro Steps:
Open RAI dashboard
Navigate the page using tab key.
Navigate to the "Model overview" section.
Observe whether all four sides of the keyboard focus indicators are visible on the "Metrices visualization" or not.
Actual Result:
Only one side of the keyboard focus indicator is visible on the "Metrices visualization" tab while navigating using tab/arrow key.
Expected Result:
All four sides of the keyboard focus indicators should be visible on the "Metrices visualization" tab while navigating using tab/arrow key.
Video before fix:
BrokenPivotFocusIndicator.mp4
Video after fix:
FixPivotFocusIndicator.mp4
Checklist