Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix line-height override on add tab button for accessibility #2449

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Dec 7, 2023

Description

fix line-height override on add tab button for accessibility

[Supporting platform – Responsible AI Dashboard – Vision Dashboard->Add component]: After applying text spacing, keyboard focus indicator overlaps on the "Add component" button.

User Experience:
Users with cognitive disability and low vision who require increased space between lines, words, and letters will not be able to access the 'Add component' button quickly and will find some difficulty to understand control as the keyboard focus indicator overlaps with the button.

Pre-Requisite:
Go to - https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne?hl=en
Click on ‘Add to Chrome’ button.
After adding, you should find Stylus icon on the tool bar, click it to open drop down menu.
Select ‘Manage Styles’ from the menu.
On the manage styles screen, click on ‘Create new Style’.
The New style screen would open, here give a suitable name for your new style e.g. ‘Text spacing’
Add following CSS under ‘Code’ field –

* {
    line-height: 1.5 !important;
    letter-spacing: 0.12em !important;
    word-spacing: 0.16em !important;
}
p
{ 
  margin-bottom: 2em !important;
}

Click on ‘Save’. Now you should be able to see the style applied automatically on the page including the content displayed within iFrames.

Repro Steps:
Open RAI dashboard
Navigate to the "Add component" button.
Observe whether keyboard focus indicator is overlapping on the button or not.
Actual Result:
After applying text spacing, keyboard focus indicator overlaps on the "Add component" button.
Expected Result:
After applying text spacing, keyboard focus indicator should not overlap on the "Add component" button. It should be clearly visible as they appear before applying text spacing.

Screenshot before fix without style overrides (no bug present):
image

Screenshot before fix with style overrides (see bug with focus window):
image

Screenshot after fix without style overrides:
image

Screenshot after fix with style overrides (bug fixed):
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/component-box-accessible branch from 770ea66 to ef583ac Compare December 7, 2023 19:39
2 similar comments
@imatiach-msft imatiach-msft merged commit 8cbf3eb into main Dec 8, 2023
@imatiach-msft imatiach-msft deleted the ilmat/component-box-accessible branch December 8, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants