fix RAI dashboard treat as categorical accessibility on new cohort create #2446
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
imatiach-msft
force-pushed
the
ilmat/treat-as-categorical-accessibility-fix
branch
from
4a29a75 to
bb33193
Compare
1 similar comment
Advitya17
approved these changes
Dec 6, 2023
hawestra
approved these changes
Dec 6, 2023
imatiach-msft
deleted the
ilmat/treat-as-categorical-accessibility-fix
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix RAI dashboard treat as categorical accessibility on new cohort create
[Screen reader – Responsible AI Dashboard – Vision Dashboard>New cohort]: Screen reader does not announce the associated text information which appears after selecting the "Treat as categorical" checkbox.
User Experience:
Visually impaired people who depend on screen readers for navigation will get impacted if screen reader does not announce the associated text which appears on the screen after selecting the checkbox. Due to this the end user will miss the information which is related to the value combo box and cannot access it precisely.
Note: User credentials should NOT be included in the bug.
Pre-Requisite: Turn on the screen reader (NVDA)
Repro Steps:
Open RAI dashboard
"Analyse_ model" page appears.
Navigate to the "New cohort" button and invoke it.
Navigate to the Treat as categorical" checkbox and select it.
Observe whether screen reader announces the associated text which appears after selecting the Treat as categorical" checkbox or not.
Actual Result:
Screen reader does not announce the associated text which appears after selecting the "Treat as categorical" checkbox.
Observation:
After selecting the Treat as categorical" checkbox, the screen reader announces as "Checked".
After selecting the Treat as categorical" checkbox, Narrator and JAWS announces as "Checked".
Expected Result:
Screen reader should announce the associated text information which appears after selecting the "Treat as categorical" checkbox.
Example: After selecting the Treat as categorical" checkbox, the screen reader should announce as "Checked - # of unique values: 28 and by unchecking it, the screen reader should announce as "Unchecked - Min 0 Max 27".
Checklist