fix flaky object detection vision notebook test by allowing range of feature cohorts to be specified #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature cohorts to be specified
imatiach-msft
requested review from
vinuthakaranth,
tongyu-microsoft,
romanlutz,
RubyZ10,
xuke444 and
hawestra
as code owners
Advitya17
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to:
#2341
It looks like these object detection notebook tests have become flaky again recently. The notebook seems to sometimes generate 2 and at other times 3 cohorts on linux builds when selecting mean_pixel_value in the unit tests to generate the feature cohorts for object detection - recently it seems to have switched back due to some environment difference and the builds aren't passing again. This seems to be a numerical difference caused by the packages installed. Due to the flakiness, I've made the UI tests more robust by checking for a range of cohorts on linux instead of a single value.
Checklist