Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate metrics #2363

Closed
wants to merge 5 commits into from
Closed

Conversation

jamesbchao
Copy link
Contributor

Description

One-liner change to add back aggregate torchmetrics as per: https://msdata.visualstudio.com/Vienna/_queries/edit/2646440/?queryId=7b8f40a5-dea1-4516-a248-f93f2cc1ce66

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft
Copy link
Contributor

@jamesbchao we are waiting for next torchmetrics release before we can add that argument back, there's some story around this issue

@jamesbchao
Copy link
Contributor Author

@jamesbchao we are waiting for next torchmetrics release before we can add that argument back, there's some story around this issue

Hi Ilya, are you referring to torchmetrics v 1.2? I tried running the app with the new line and it seems to work.

Screenshot (14)

@imatiach-msft
Copy link
Contributor

imatiach-msft commented Sep 29, 2023

@jamesbchao oh I see, indeed it was just released:
https://github.com/Lightning-AI/torchmetrics/releases

From release notes:

Update to Mean Average Precision
MeanAveragePrecision, the most widely used metric for object detection in computer vision, now supports two new arguments: average and backend.

The average argument controls averaging over multiple classes. By the core definition, the default way is macro averaging, where the metric is calculated for each class separately and then averaged together. This will continue to be the default in Torchmetrics, but now we also support the setting average="micro". Every object under this setting is essentially considered to be the same class, and the returned value is, therefore, calculated simultaneously over all objects.

@imatiach-msft
Copy link
Contributor

@jamesbchao seems it should be average, not aggregate, according to:

Lightning-AI/torchmetrics#2004
Lightning-AI/torchmetrics#2018

@imatiach-msft
Copy link
Contributor

closing as related PR has been merged:
#2412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants