Forecasting: generate time series as cohorts #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olbox into romanlutz/forecasting_cohort_gen
romanlutz
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 108 108
Lines 5415 5415
=======================================
Hits 5004 5004
Misses 411 411
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 similar comments
1 similar comment
hawestra
approved these changes
Sep 25, 2023
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/GenerateTimeSeriesCohorts.ts
Outdated
Show resolved
Hide resolved
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/GenerateTimeSeriesCohorts.ts
Outdated
Show resolved
Hide resolved
RubyZ10
reviewed
Sep 25, 2023
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/GenerateTimeSeriesCohorts.ts
Show resolved
Hide resolved
RubyZ10
approved these changes
Sep 25, 2023
…olbox into romanlutz/forecasting_cohort_gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With raiwidgets we can inject time series as prebuilt cohorts, but in Studio we don't have that option, so this PR adds the functionality to generate time series as cohorts if they weren't provided. This only happens if time series ID features were provided, otherwise we assume that there is only a single time series in the dataset.
While working on this I also uncovered a bug in the function
IsTimeOrTimeSeriesIdColumn. Checking for datetime features doesn't quite make sense since we populate theindexof the dataset with the time column that we get from Python. I removed that check since it actually broke the single time series case.Overall, I also added two new test scenarios that capture the time series generation cases.
There are no UI changes.
Checklist