causal_manager.py: Move user config validation checks from compute() to add() #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add() Signed-off-by: Gaurav Gupta <[email protected]>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft,
hawestra and
romanlutz
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
+ Coverage 88.58% 90.68% +2.10%
==========================================
Files 134 59 -75
Lines 7631 2330 -5301
==========================================
- Hits 6760 2113 -4647
+ Misses 871 217 -654
Flags with carried forward coverage won't be shown. Click here to find out more. |
Advitya17
approved these changes
Sep 18, 2023
imatiach-msft
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like these checks should be part to add() so stop the unnecessary compute() execution.
Checklist