Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error analysis for RAITextInsights displaying all incorrect instances for text labels #2325

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

imatiach-msft
Copy link
Contributor

Description

On the DBPedia dataset, fix error analysis for RAITextInsights displaying all incorrect instances for text labels:
image
Note this is only happening for a particular multiclass text classification case where the predicted label is a numpy int type.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-text-ea-all-incorrect branch from 6134580 to 3043de9 Compare September 7, 2023 19:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #2325 (11a682d) into main (7b7054f) will decrease coverage by 9.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2325      +/-   ##
==========================================
- Coverage   88.53%   78.68%   -9.86%     
==========================================
  Files         133       26     -107     
  Lines        7581     2191    -5390     
==========================================
- Hits         6712     1724    -4988     
+ Misses        869      467     -402     
Flag Coverage Δ
unittests 78.68% <100.00%> (-9.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ponsibleai_text/managers/error_analysis_manager.py 88.65% <100.00%> (+0.79%) ⬆️

... and 109 files with indirect coverage changes

1 similar comment
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-text-ea-all-incorrect branch from 3043de9 to 6ec14db Compare September 8, 2023 16:56
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-text-ea-all-incorrect branch from 6ec14db to 11a682d Compare September 8, 2023 17:28
1 similar comment
@imatiach-msft imatiach-msft merged commit a7f4c8c into main Sep 8, 2023
@imatiach-msft imatiach-msft deleted the ilmat/fix-text-ea-all-incorrect branch September 8, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants