Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_complex_regression_pipeline to sklearn_model_utils.py #2318

Merged
merged 10 commits into from
Sep 7, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Sep 6, 2023

Description

Add create_complex_regression_pipeline to sklearn_model_utils.py. Some of the test code in dice-ml can be migrated to rai_test_utils. So adding some functionality in rai_test_utils which can be upstreamed into dice-ml.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #2318 (618f8c9) into main (61c70d0) will increase coverage by 3.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2318      +/-   ##
==========================================
+ Coverage   88.42%   92.37%   +3.95%     
==========================================
  Files         133      107      -26     
  Lines        7575     5391    -2184     
==========================================
- Hits         6698     4980    -1718     
+ Misses        877      411     -466     
Flag Coverage Δ
unittests 92.37% <100.00%> (+3.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...st_utils/rai_test_utils/models/sklearn/__init__.py 100.00% <ø> (ø)
...i_test_utils/models/sklearn/sklearn_model_utils.py 74.54% <100.00%> (+3.11%) ⬆️
rai_test_utils/rai_test_utils/version.py 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@gaugup gaugup enabled auto-merge (squash) September 6, 2023 18:14
@gaugup gaugup enabled auto-merge (squash) September 7, 2023 21:34
2 similar comments
@gaugup gaugup merged commit 6eea36c into main Sep 7, 2023
@gaugup gaugup deleted the gaugup/AddSklearnRegressionPipeline branch September 7, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants