Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release erroranalysis 0.5.1 #2304

Merged
merged 20 commits into from
Sep 5, 2023
Merged

Release erroranalysis 0.5.1 #2304

merged 20 commits into from
Sep 5, 2023

Conversation

Advitya17
Copy link
Collaborator

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #2304 (63e3a17) into main (791d646) will increase coverage by 3.71%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2304      +/-   ##
==========================================
+ Coverage   88.66%   92.38%   +3.71%     
==========================================
  Files         133      107      -26     
  Lines        7580     5381    -2199     
==========================================
- Hits         6721     4971    -1750     
+ Misses        859      410     -449     
Flag Coverage Δ
unittests 92.38% <100.00%> (+3.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
erroranalysis/erroranalysis/version.py 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

1 similar comment
5 similar comments
- if: ${{ matrix.packageDirectory == 'rai_test_utils' }}
name: Install package extras
shell: bash -l {0}
- name: Install test extras
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this object detection section be removed altogether here, since we are not installing torch?

Copy link
Collaborator Author

@Advitya17 Advitya17 Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, these dependencies only contain requests and Pillow. None of the requirements-object-detection.txt files contain torch, torch is always installed via conda. I added this step for tests to work across rai_test_utils and erroranalysis that utilizes methods from rai test utils in its tests.

Considering rai test utils has common code to be used by other modules for testing + isn't part of any other builds, this step ensures that any non-torch tests (eg - loading image datasets) can run across all the other python modules.

5 similar comments
1 similar comment
@Advitya17 Advitya17 merged commit 98f1640 into main Sep 5, 2023
@Advitya17 Advitya17 deleted the agemawat/ea_patch branch September 5, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants