-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release erroranalysis 0.5.1 #2304
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
+ Coverage 88.66% 92.38% +3.71%
==========================================
Files 133 107 -26
Lines 7580 5381 -2199
==========================================
- Hits 6721 4971 -1750
+ Misses 859 410 -449
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 similar comment
5 similar comments
.github/workflows/CI-python.yml
Outdated
- if: ${{ matrix.packageDirectory == 'rai_test_utils' }} | ||
name: Install package extras | ||
shell: bash -l {0} | ||
- name: Install test extras |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this object detection section be removed altogether here, since we are not installing torch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, these dependencies only contain requests
and Pillow
. None of the requirements-object-detection.txt
files contain torch, torch is always installed via conda. I added this step for tests to work across rai_test_utils
and erroranalysis
that utilizes methods from rai test utils in its tests.
Considering rai test utils has common code to be used by other modules for testing + isn't part of any other builds, this step ensures that any non-torch tests (eg - loading image datasets) can run across all the other python modules.
Description
Checklist