-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAIInsights: prevent failures on optional methods & fix feature range formatting for timestamps #2258
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
+ Coverage 92.26% 93.10% +0.84%
==========================================
Files 103 103
Lines 5171 5179 +8
==========================================
+ Hits 4771 4822 +51
+ Misses 400 357 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add unit tests for these changes?
1 similar comment
Added tests as requested. |
Description
With optional methods such as
forecast_quantiles
we need to be able to check if the model has the method at all without getting a failure. This PR adjusts the handling slightly to prevent unintended issues.Secondly, the feature ranges need to be specified in a JSON-serializable format, so we're storing them as strings now.
Checklist