fix for aggregate parameter passed to torchmetrics #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/torchmetrics-fix
branch
from
9c550d6 to
b4e39f0
Compare
1 similar comment
Advitya17
approved these changes
Aug 10, 2023
| metrics = rai_insights.compute_object_detection_metrics( | ||
| selection_indexes, aggregate_method, class_name, iou_threshold, | ||
| object_detection_cache) | ||
| assert len(metrics) == 2 |
There was a problem hiding this comment.
maybe also assert the number of metrics per cohort is 3?
imatiach-msft
force-pushed
the
ilmat/torchmetrics-fix
branch
2 times, most recently
from
08c09b7 to
261512f
Compare
1 similar comment
imatiach-msft
force-pushed
the
ilmat/torchmetrics-fix
branch
from
261512f to
074ec04
Compare
imatiach-msft
force-pushed
the
ilmat/torchmetrics-fix
branch
from
074ec04 to
0764fae
Compare
Codecov Report
@@ Coverage Diff @@
## main #2235 +/- ##
===========================================
- Coverage 88.58% 75.42% -13.16%
===========================================
Files 129 14 -115
Lines 7366 1241 -6125
===========================================
- Hits 6525 936 -5589
+ Misses 841 305 -536
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MeanAveragePrecision no longer takes in an aggregate parameter. This PR fixes this issue by removing it and adding a test to validate the compute_object_detection_metrics call. Note I do not remove the UI changes here since we may still want to keep this parameter when computing in aggregate metrics across classes - but we need to call a different method in this case anyway, and this is currently not yet supported.
Checklist