OD model type support in responsibleai_vision for EA #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #2233 +/- ##
===========================================
- Coverage 89.17% 78.72% -10.46%
===========================================
Files 121 26 -95
Lines 6634 2190 -4444
===========================================
- Hits 5916 1724 -4192
+ Misses 718 466 -252
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 similar comment
imatiach-msft
approved these changes
Sep 6, 2023
| pred_labels = [str(i) for i in pred_labels] | ||
| # concatenate all predicted labels into a single string | ||
| predictions_joined.append(','.join(pred_labels)) | ||
| self.predictions = np.array(predictions_joined) |
There was a problem hiding this comment.
is there a test covering this case already?
There was a problem hiding this comment.
Great catch! Didn't see a dedicated test_error_analysis_manager.py file in responsibleai_vision, but saw a flag in the main testing file. Some weird bug in pandas it seems when I test it locally, so can work on it in the next PR.
1 similar comment
Advitya17
force-pushed
the
agemawat/ea_rai_vision
branch
from
cddf833 to
319eb66
Compare
…olbox into agemawat/ea_rai_vision
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OD support in EA due to the hybrid use-case of OD models.
Description
Checklist