Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build CI failing due to old pip-tools failing with latest pip #2200

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix build CI failing due to old pip-tools failing with latest pip #2200

merged 1 commit into from
Aug 2, 2023

Conversation

imatiach-msft
Copy link
Contributor

Description

fix build CI failing due to old pip-tools failing with latest pip

Currently builds on main are failing with the errors:

File "/opt/hostedtoolcache/Python/3.8.[17](https://github.com/microsoft/responsible-ai-toolbox/actions/runs/5730992430/job/15530945337?pr=2173#step:7:18)/x64/lib/python3.8/site-packages/piptools/sync.py", line 11, in <module>
    from pip._internal.commands.freeze import DEV_PKGS
ImportError: cannot import name 'DEV_PKGS' from 'pip._internal.commands.freeze' (/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pip/_internal/commands/freeze.py)
Error: Process completed with exit code 1.

According to issues such as:
pypa/pip#12153
The fix is to update to the latest pip-tools. Hence, upgrading pip-tools in this PR to latest version 7.1.0 on pypi to see if it will resolve the build errors. It seems we previously added a bound in the past because those pip-tools releases broke us, but in this case it was a new pip update that seems to have caused the errors.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-pip-ci-python-err branch from c235bfc to 412f6f2 Compare August 1, 2023 19:45
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-pip-ci-python-err branch from 412f6f2 to 775739e Compare August 1, 2023 20:09
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-pip-ci-python-err branch 4 times, most recently from 6ad9f24 to f7e42b4 Compare August 1, 2023 20:31
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-pip-ci-python-err branch from f7e42b4 to 1ec79c1 Compare August 1, 2023 20:52
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

4 similar comments
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-pip-ci-python-err/dashboard/index.html

@imatiach-msft imatiach-msft merged commit 0327bb2 into main Aug 2, 2023
@imatiach-msft imatiach-msft deleted the ilmat/fix-pip-ci-python-err branch August 2, 2023 14:40
kicha0 pushed a commit that referenced this pull request Aug 2, 2023
@imatiach-msft @kicha0
fix build CI failing due to old pip-tools failing with latest pip (#2200
6093478 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinuthakaranth vinuthakaranth vinuthakaranth approved these changes

@gaugup gaugup gaugup approved these changes

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imatiach-msft @vinuthakaranth @gaugup