-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require pillow>=10.0.0, catch drise failure due to low mask_res or num_masks #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
approved these changes
Jul 14, 2023
1 similar comment
Advitya17
approved these changes
Jul 14, 2023
ziqi-ma
approved these changes
Jul 14, 2023
1 similar comment
3 similar comments
1 similar comment
Codecov Report
@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
- Coverage 78.34% 78.09% -0.26%
==========================================
Files 26 26
Lines 2152 2159 +7
==========================================
Hits 1686 1686
- Misses 466 473 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In telemetry, we found that two exceptions were thrown. Firstly, drise throws
ValueError
whennum_masks
ormask_res
are too low. This is caught by the try-except block and the_get_fail_str
method subsequently runs into anAttributeError
because it doesn't have atextsize
method. This is due to a breaking change in v10.0.0 of Pillow.This PR therefore
textbbox
instead oftextsize
from Pillow which avoids the second exceptionValueError
from drise and provides a corresponding user error with informative message to the user.A simple way to reproduce this is to take our dpv2 test cases and run
test_object_detection_pipeline_rai.yaml
withnum_masks=1
andmax_evals=10
(to make it faster).Checklist