fix build failures due to new joblib 1.3.0 release failing on windows with python 3.7 #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft,
hawestra and
romanlutz
as code owners
imatiach-msft
commented
Jun 28, 2023
| @@ -13,6 +13,8 @@ ml-wrappers>=0.4.0 | |||
|
|
|||
| # Jupyter dependency that fails with python 3.6 | |||
| pywinpty==2.0.2; python_version <= '3.6' and sys_platform == 'win32' | |||
| # fix for recent joblib release and windows python 3.7 builds | |||
There was a problem hiding this comment.
not sure if I should just pin the requirements.txt to make sure we don't have this issue in prod or that might be too heavy-handed and I should go with the less intrusive fix to only resolve our build failures (who knows what the ramifications might be for the more heavy-handed fix... and relatively few people probably use this on python 3.7 w/ windows anyway)
There was a problem hiding this comment.
Python 3.7 reached EOL yesterday. Perhaps it's time to drop it 🙂
Codecov Report
@@ Coverage Diff @@
## main #2155 +/- ##
==========================================
+ Coverage 91.02% 92.21% +1.19%
==========================================
Files 115 103 -12
Lines 6061 5140 -921
==========================================
- Hits 5517 4740 -777
+ Misses 544 400 -144
Flags with carried forward coverage won't be shown. Click here to find out more. |
gaugup
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Description
Fix build failures due to new joblib 1.3.0 release failing on windows with python 3.7.
It looks like our gated builds broke again today with joblib 1.3.0 release 8 hours ago:
Python 3.7 compatibility issue introduced by release 1.3.0 · Issue #1469 · joblib/joblib (github.com)
See example build error log:
add retry logic to common vision utils to make tests more robust · microsoft/responsible-ai-toolbox@fd82d2c (github.com)
Checklist