Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table view multi-selection #2087

Merged
merged 3 commits into from
May 30, 2023
Merged

Fix table view multi-selection #2087

merged 3 commits into from
May 30, 2023

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented May 26, 2023

Description

In individual feature importance view, there are a limitation for selecting 5 items only, but user can still click on the group header to select all items.
In this PR

  1. we hide the select all button on group header
  2. even we hide the select all button, customer can still click on the header to select all, so the we change the group header toggle behavior from select to collapse
  3. Both Data Analysis and Individual feature importance leverage table view, the behavior in Data Analysis is not changed

Gif before fix
multSB

Gif after fix
multSA

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: RubyZ10 <[email protected]>
@RubyZ10 RubyZ10 marked this pull request as ready for review May 30, 2023 18:44
@RubyZ10 RubyZ10 enabled auto-merge (squash) May 30, 2023 20:23
@RubyZ10 RubyZ10 merged commit 0bbd92f into main May 30, 2023
@RubyZ10 RubyZ10 deleted the zhenzhu/fixBug branch May 30, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants