Remove un-needed requests dependency
#2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
gaugup
requested review from
imatiach-msft,
xuke444,
romanlutz,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2083 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 101 101
Lines 5017 5017
=======================================
Hits 4637 4637
Misses 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. |
romanlutz
approved these changes
May 25, 2023
tongyu-microsoft
approved these changes
May 25, 2023
gaugup
changed the title
requests dependency and remove pinsrequests dependency
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove un-needed
requestsdependency. Looks like the dependent bot in the repo is flagging the pinned version ofrequests. Examining the code in repo, lot of packages don't userequestsin tests.Checklist