Show message to select bubble after bubble plot renders #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinutha karanth <[email protected]>
vinuthakaranth
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
RubyZ10 and
hawestra
as code owners
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/buttonsOnLoading
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/buttonsOnLoading
Signed-off-by: vinutha karanth <[email protected]>
gaugup
approved these changes
May 31, 2023
imatiach-msft
approved these changes
May 31, 2023
tongyu-microsoft
approved these changes
May 31, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show message to select bubble after bubble plot renders. This change makes the whole local importance component to not render while the bubble chart is loading.
Before change:
The message 'Select a bubble...' appeared before the bubble plot was rendered, while it was loading.
After change:
The message 'Select a bubble...' appears once the bubble chart has been rendered successfully (not while it is loading).
Checklist