Raise warning in case the test data has missing values #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
responsibleai/tests/rai_insights/test_rai_insights_get_feature_ranges.py
Outdated
Show resolved
Hide resolved
imatiach-msft
approved these changes
May 17, 2023
imatiach-msft
approved these changes
May 17, 2023
Signed-off-by: Gaurav Gupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
+ Coverage 92.34% 93.11% +0.76%
==========================================
Files 100 53 -47
Lines 4967 2019 -2948
==========================================
- Hits 4587 1880 -2707
+ Misses 380 139 -241
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Gaurav Gupta <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raise warning in case the test data has missing values to make user aware of missing data columns. Also, adding a test to make sure that missing values in test data doesn't affect
get_feature_rangesfunction.Checklist