Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky HomeBrew Install #2058

Merged
merged 8 commits into from
May 15, 2023
Merged

Remove flaky HomeBrew Install #2058

merged 8 commits into from
May 15, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented May 12, 2023

Description

The homebrew install was failing with error "Error: can't modify frozen Hash". @imatiach-msft suggested we can remove this.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

4 similar comments
@gaugup gaugup changed the title [WIP] Fix flaky HomeBrew Install Remove flaky HomeBrew Install May 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #2058 (6de1e38) into main (b890c23) will decrease coverage by 1.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
- Coverage   93.63%   92.33%   -1.30%     
==========================================
  Files          31       98      +67     
  Lines         581     4957    +4376     
==========================================
+ Hits          544     4577    +4033     
- Misses         37      380     +343     
Flag Coverage Δ
unittests 92.33% <ø> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 67 files with indirect coverage changes

Signed-off-by: Gaurav Gupta <[email protected]>
@gaugup gaugup enabled auto-merge (squash) May 15, 2023 22:28
@gaugup gaugup merged commit 7e8fdaf into main May 15, 2023
@gaugup gaugup deleted the gaugup/RetryHomebrewInstall branch May 15, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants