Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix robot page exception on feature importance when dropped_feature is defined #2051

Merged
merged 2 commits into from
May 4, 2023
Merged

Fix robot page exception on feature importance when dropped_feature is defined #2051

merged 2 commits into from
May 4, 2023

Conversation

tongyu-microsoft
Copy link
Contributor

@tongyu-microsoft tongyu-microsoft commented May 3, 2023 •
edited
Loading

This PR fixes the bug where the index for x axis and y axisfor feature importances plot was not correctly set when dropped_feature has length > 0.

Description

There are two issues:

  1. y axis: Feature importances are only calculated for non-dropped features. So we should pass featureIndex instead of featureIndexBeforeDrop to yKey (change on line 602)
  2. x axis: this.handleFeatureSelection is a shared method for both and FeatureOptions' . We should pass indexAfterDrop to this.handleFeatureSelection method.
    feautureImportanceRobotPage

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@github-actions
Copy link

github-actions bot commented May 3, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fixFeatureImportanceError/dashboard/index.html

@github-actions
Copy link

github-actions bot commented May 4, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fixFeatureImportanceError/dashboard/index.html

@tongyu-microsoft tongyu-microsoft merged commit d6b0d10 into main May 4, 2023
@tongyu-microsoft tongyu-microsoft deleted the tongy/fixFeatureImportanceError branch May 4, 2023 02:01
@imatiach-msft imatiach-msft mentioned this pull request Jun 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@romanlutz romanlutz Awaiting requested review from romanlutz

@gaugup gaugup Awaiting requested review from gaugup gaugup is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tongyu-microsoft @imatiach-msft