Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated DataFrame indexer type in Error Analysis package #2019

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

JarvisG495
Copy link
Contributor

Description

In latest Pandas version(2.0.0), passing a set as an indexer is deprecated, and will raise an error:
G S4W55~CZU)UN P3(F3UM

Convert the indexer type to list to accomodate newer versions of Pandas

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #2019 (4c2a28d) into main (2dc957c) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
- Coverage   92.33%   92.15%   -0.18%     
==========================================
  Files          95       64      -31     
  Lines        4903     4322     -581     
==========================================
- Hits         4527     3983     -544     
+ Misses        376      339      -37     
Flag Coverage Δ
unittests 92.15% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...is/erroranalysis/_internal/surrogate_error_tree.py 89.57% <100.00%> (ø)

... and 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft merged commit 4dd11fa into microsoft:main Mar 31, 2023
@JarvisG495 JarvisG495 deleted the fix-pd-df-indexer-type branch March 31, 2023 19:02
@imatiach-msft imatiach-msft mentioned this pull request Apr 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants