Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated example link in Error Analysis README #1965

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

JarvisG495
Copy link
Contributor

Description

Update the link to the housing price prediction example notebook in Error Analysis README to fix 404.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@JarvisG495
Copy link
Contributor Author

btw, I'm wondering if other example links in this README should be updated in this PR as well -- it seems they are also outdated but they can be automatically redirected to the correct files..

@romanlutz
Copy link
Contributor

btw, I'm wondering if other example links in this README should be updated in this PR as well -- it seems they are also outdated but they can be automatically redirected to the correct files..

Hi @JarvisG495 thanks for fixing this! Which other links are broken? If you happen to be able to update the others, too, you can feel free to add it in this PR. We always want them to be up-to-date, but sadly sometimes we miss a few. Thanks for helping us keep it in shape 🙂

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imatiach-msft imatiach-msft merged commit c8a37ae into microsoft:main Feb 13, 2023
@JarvisG495
Copy link
Contributor Author

btw, I'm wondering if other example links in this README should be updated in this PR as well -- it seems they are also outdated but they can be automatically redirected to the correct files..

Hi @JarvisG495 thanks for fixing this! Which other links are broken? If you happen to be able to update the others, too, you can feel free to add it in this PR. We always want them to be up-to-date, but sadly sometimes we miss a few. Thanks for helping us keep it in shape 🙂

Actually they're not broken -- I just found other links were not very "consistent" when I was updating the link to the housing price prediction example notebook: they are '.../microsoft/responsible-ai-widgets/blob/master/notebooks/.../*.ipynb' instead of '.../microsoft/responsible-ai-toolbox/blob/main/notebooks/.../*.ipynb'. Since they could be automatically redirected to this repo and main branch, I was not sure if they needed to be updated so I didn't modify them in this PR.

Screen Shot 2023-02-13 at 4 29 54 PM

Screen Shot 2023-02-13 at 4 26 08 PM

@JarvisG495 JarvisG495 deleted the FixExampleLink branch February 13, 2023 21:32
@romanlutz
Copy link
Contributor

btw, I'm wondering if other example links in this README should be updated in this PR as well -- it seems they are also outdated but they can be automatically redirected to the correct files..

Hi @JarvisG495 thanks for fixing this! Which other links are broken? If you happen to be able to update the others, too, you can feel free to add it in this PR. We always want them to be up-to-date, but sadly sometimes we miss a few. Thanks for helping us keep it in shape 🙂

Actually they're not broken -- I just found other links were not very "consistent" when I was updating the link to the housing price prediction example notebook: they are '.../microsoft/responsible-ai-widgets/blob/master/notebooks/.../*.ipynb' instead of '.../microsoft/responsible-ai-toolbox/blob/main/notebooks/.../*.ipynb'. Since they could be automatically redirected to this repo and main branch, I was not sure if they needed to be updated so I didn't modify them in this PR.

Screen Shot 2023-02-13 at 4 29 54 PM Screen Shot 2023-02-13 at 4 26 08 PM

Ah yes! "master" was replaced by "main" but the auto-redirects work. Still, it would be best to replace it. @JarvisG495 feel free to send a PR if you have time 🙂

@JarvisG495
Copy link
Contributor Author

Ah yes! "master" was replaced by "main" but the auto-redirects work. Still, it would be best to replace it. @JarvisG495 feel free to send a PR if you have time 🙂

ok, I will send another PR to update them soon 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants