Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot page exception on data explorer #1963

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Conversation

tongyu-microsoft
Copy link
Contributor

There was an ICM for robot page exception on data explorer. We have seen similar issue before on undefined this.props.cohorts[this.props.selectedCohortIndex].

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Copy link
Contributor

@gaugup gaugup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other places in the code that we will run into this error? Why not fix this in all places?

@tongyu-microsoft
Copy link
Contributor Author

tongyu-microsoft commented Feb 10, 2023

Are there other places in the code that we will run into this error? Why not fix this in all places?

this is the only place, we have handled all scenarios for this specific issue on this.props.cohorts[this.props.selectedCohortIndex]
image

@tongyu-microsoft tongyu-microsoft merged commit 8665791 into main Feb 11, 2023
@tongyu-microsoft tongyu-microsoft deleted the tongy/fixRobotPAGE branch February 11, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants