Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table view feature value && scroll bar #1954

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix table view feature value && scroll bar #1954

merged 1 commit into from
Feb 7, 2023

Conversation

RubyZ10
Copy link
Contributor

@RubyZ10 RubyZ10 commented Feb 7, 2023

This PR fix two things

  1. the feature value in table view is wrong
    When creating a new cohort and select treat as categorical, the value displayed in table value is wrong. It is displaying the index of the value in its sortedCategricalValues array
    It should display its actual value

selecting cohort 8 which has filter: age includes 18
image

Before change
image

After change
image

  1. fix scroll bar

Before change
image

After change
image

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@RubyZ10
fix table view
30b4ca7 
Signed-off-by: RubyZ10 <[email protected]>
@RubyZ10 RubyZ10 marked this pull request as ready for review February 7, 2023 22:08
@RubyZ10 RubyZ10 enabled auto-merge (squash) February 7, 2023 22:10
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/zhenzhu/fixTableView/dashboard/index.html

@RubyZ10 RubyZ10 merged commit d7dd849 into main Feb 7, 2023
@RubyZ10 RubyZ10 deleted the zhenzhu/fixTableView branch February 7, 2023 23:42
@imatiach-msft imatiach-msft mentioned this pull request Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@vinuthakaranth vinuthakaranth vinuthakaranth approved these changes

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubyZ10 @imatiach-msft @vinuthakaranth