fix mean absolute error metric calculation in model overview panel #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth,
romanlutz and
hawestra
as code owners
gaugup
approved these changes
Feb 7, 2023
romanlutz
approved these changes
Feb 8, 2023
|
I guess we should also consider adding at least a few basic tests if we intend to keep these definitions around. |
imatiach-msft
force-pushed
the
ilmat/fix-mean-abs-err
branch
from
d7133ca to
8e1bcc6
Compare
imatiach-msft
force-pushed
the
ilmat/fix-mean-abs-err
branch
from
8e1bcc6 to
7984752
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During customer session, I noticed the mean absolute error metric looked incorrect for their data. Indeed, it seems we were not taking the "mean" of the data but just summing the error. To fix the issue, I divided by the count to get the correct metric.
Before:
After:
Note how mean absolute error and mean squared error look a lot more similar now.
Checklist