Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow ymls to pin pip-tools to below 6.12.2 #1931

Merged
merged 8 commits into from
Feb 1, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jan 31, 2023

Description

Looks like pip-tools (6.12.2) had a release today which broke our builds. Looks like it maybe because of the issue jazzband/pip-tools#1804 where you can provide some special paths for requirements and cannot merge two sets of requirements. This PR upper bounds pip-tools in all the yml workflow files where we install pip-tools.

Also, looks like a change in CI-python.yml won't run the python tests due to directory policy. Also, adding another rule when the python tests should run.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

3 similar comments
@gaugup gaugup changed the title [WIP] Update CI-python.yml to pin pip-tools to below 6.12.2 Update CI-python.yml to pin pip-tools to below 6.12.2 Jan 31, 2023
@gaugup gaugup changed the title Update CI-python.yml to pin pip-tools to below 6.12.2 Update workflow ymls to pin pip-tools to below 6.12.2 Jan 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #1931 (7a33fda) into main (e15a9d4) will decrease coverage by 2.64%.
The diff coverage is n/a.

❗ Current head 7a33fda differs from pull request most recent head 90882c2. Consider uploading reports for the commit 90882c2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1931      +/-   ##
==========================================
- Coverage   93.35%   90.72%   -2.64%     
==========================================
  Files          93       46      -47     
  Lines        4621     1897    -2724     
==========================================
- Hits         4314     1721    -2593     
+ Misses        307      176     -131     
Flag Coverage Δ
unittests 90.72% <ø> (-2.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/responsibleai/managers/error_analysis_manager.py
responsibleai/responsibleai/feature_metadata.py
responsibleai/responsibleai/_interfaces.py
responsibleai/responsibleai/exceptions.py
...bleai/responsibleai/_tools/causal/causal_result.py
...ai/responsibleai/_tools/counterfactual/__init__.py
...leai/responsibleai/modelanalysis/model_analysis.py
responsibleai/responsibleai/_config/__init__.py
...ai/responsibleai/_tools/causal/causal_constants.py
...sibleai/responsibleai/rai_insights/rai_insights.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

2 similar comments
@gaugup gaugup merged commit e795d44 into main Feb 1, 2023
@gaugup gaugup deleted the gaugup/PinPipTools branch February 1, 2023 01:42
RubyZ10 pushed a commit that referenced this pull request Feb 7, 2023
* Update CI-python.yml

* Update CI-python.yml

* Update CI-python.yml

* Update CI-python.yml

* Update CI-rai_core_flask-pytest.yml

* Update CI-e2e-notebooks.yml

* Update CI-notebook.yml

* Update CI-raiwidgets-pytest.yml

Signed-off-by: RubyZ10 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants