Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate load() and save() for large data #1930

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jan 31, 2023

Description

Remove duplicate load() and save() for large data

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

1 similar comment
@gaugup gaugup enabled auto-merge (squash) February 1, 2023 01:42
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #1930 (62810e9) into main (e795d44) will increase coverage by 2.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
+ Coverage   90.72%   93.34%   +2.62%     
==========================================
  Files          46       93      +47     
  Lines        1897     4612    +2715     
==========================================
+ Hits         1721     4305    +2584     
- Misses        176      307     +131     
Flag Coverage Δ
unittests 93.34% <ø> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 93.30% <ø> (ø)
responsibleai/responsibleai/__version__.py 100.00% <0.00%> (ø)
...ai/responsibleai/_tools/error_analysis/__init__.py 100.00% <0.00%> (ø)
...sponsibleai/responsibleai/rai_insights/__init__.py 100.00% <0.00%> (ø)
...ai/responsibleai/_tools/causal/causal_constants.py 100.00% <0.00%> (ø)
...sponsibleai/responsibleai/managers/base_manager.py 95.23% <0.00%> (ø)
...tools/error_analysis/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
...ibleai/_tools/causal/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_config/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_internal/constants.py 100.00% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup merged commit 0807da6 into main Feb 1, 2023
@gaugup gaugup deleted the gaugup/RemoveDuplicateLoadSaveLargeData branch February 1, 2023 03:33
RubyZ10 pushed a commit that referenced this pull request Feb 7, 2023
* Remove duplicate load() and save() for large data

Signed-off-by: Gaurav Gupta <[email protected]>

* Update CI-python.yml

* Update CI-python.yml

---------

Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: RubyZ10 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants