Move sort operation of out render() in CausalAggregateView
#1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
gaugup
requested review from
tongyu-microsoft,
romanlutz,
vinuthakaranth,
xuke444,
RubyZ10 and
hawestra
as code owners
vinuthakaranth
approved these changes
Feb 1, 2023
...causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalAnalysisView.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaurav Gupta <[email protected]>
RubyZ10
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Move sort operation of out `render()` in `CausalAggregateView` Signed-off-by: Gaurav Gupta <[email protected]> * Addressing code review comments Signed-off-by: Gaurav Gupta <[email protected]> --------- Signed-off-by: Gaurav Gupta <[email protected]> Signed-off-by: RubyZ10 <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@xuke444 mentioned that data operations such as sorting should not be done in render. Hence, moving the sort of the causal aggregate insights into parent component.
Checklist